[ https://issues.apache.org/jira/browse/HBASE-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417146#comment-13417146 ]
Lars Hofhansl commented on HBASE-6418: -------------------------------------- It was late yesterday so I was terse. This is (partially) documented in Delete.java. Version delete markers are bit strange to begin with. They let you target a specific version of a specific column of a specific column family (of a specific row). It's makes little sense to talk about the current time for those. That is why there is this special logic to either target a version of your choosing or the latest version. Column or Family should be using the current time unless a time is specified... As is done right now. A comment to that extend in the server code would not hurt. :) I'm happy to make a simple patch. > Minor bug in delete flow. > ------------------------- > > Key: HBASE-6418 > URL: https://issues.apache.org/jira/browse/HBASE-6418 > Project: HBase > Issue Type: Bug > Affects Versions: 0.94.0, 0.96.0, 0.94.1, 0.94.2 > Reporter: Laxman > Assignee: Laxman > > Timestamp updation in Delete flow is not considering all flavors (Delete > record, Delete Family, Delete Column) of Delete API. Currently its > considering Delete Record only. > > org.apache.hadoop.hbase.regionserver.HRegion.prepareDeleteTimestamps(Delete, > byte[]) > {code} > for (KeyValue kv: kvs) { > // Check if time is LATEST, change to time of most recent addition > if so > // This is expensive. > if (kv.isLatestTimestamp() && kv.isDeleteType()) { > {code} > Basically used a wrong API. > kv.isDeleteType() should be KeyValue.isDelete(type); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira