CCweixiao commented on PR #5589: URL: https://github.com/apache/hbase/pull/5589#issuecomment-1869333984
> The change looks straight forward so in general I think it is OK. Can we add a UT for this change? > > And also, I think the forceMajor will only trigger a major compaction in a single stripe, not all the stripes at once. So even if we request major compaction several times, how can we make sure that we will select compaction for different stripes, and finally compaction all the stripes? > > Thanks. Thanks for checking the code, at the moment, after passing the forceMajor parameter, running major compact, will indeed only compress one Stripe. The situation I'm testing here is that after the stripe count major, the region will be compacted. If you want to major all the stripes at once, you need to modify the return value of StripeCompactionRequest. I need to submit the code again and add the test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
