virajjasani commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1442559511
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java:
##########
@@ -138,6 +140,12 @@ public class HStoreFile implements StoreFile {
// Indicates if the file got compacted
private volatile boolean compactedAway = false;
+ // Indicate if the file contains live cell versions for a given column
+ // in a row. MemStore flushes generate files with all cell versions. However,
+ // compactions can generate two files, one with the live cell versions and
the other
+ // with the remaining (historical) cell versions.
+ private volatile boolean hasLiveVersions = true;
Review Comment:
I was thinking why this is not kept `false` by default, but now i realized
that it is only used by `DefaultStoreFileManager#getLiveVersionFiles` which
will only be used by callers if
`hbase.hstore.defaultengine.enable.dualfilewriter` is enabled.
Hence, unless dual file writer is enabled, this is not even used, so it's
default value here doesn't matter. Is that correct? If so, maybe we can comment
the same here so that no one tries to use this value without checking for
`hbase.hstore.defaultengine.enable.dualfilewriter` in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
