charlesconnell commented on code in PR #5628:
URL: https://github.com/apache/hbase/pull/5628#discussion_r1452503163
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:
##########
@@ -3891,11 +3891,27 @@ public TableDescriptors getTableDescriptors() {
/**
* Reload the configuration from disk.
*/
- void updateConfiguration() {
+ public void updateConfiguration() throws IOException {
LOG.info("Reloading the configuration from disk.");
// Reload the configuration from disk.
+ preUpdateConfiguration();
conf.reloadConfiguration();
configurationManager.notifyAllObservers(conf);
+ postUpdateConfiguration();
+ }
+
+ private void preUpdateConfiguration() throws IOException {
Review Comment:
+1 to this idea, this is how I did it on our private backport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
