Apache9 commented on code in PR #5629:
URL: https://github.com/apache/hbase/pull/5629#discussion_r1453447281
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java:
##########
@@ -667,46 +685,34 @@ private void readResponse() {
// this connection.
int readSoFar = getTotalSizeWhenWrittenDelimited(responseHeader);
int whatIsLeftToRead = totalSize - readSoFar;
+ LOG.debug("Unknown callId: " + id + ", skipping over this response of
" + whatIsLeftToRead
+ + " bytes");
IOUtils.skipFully(in, whatIsLeftToRead);
if (call != null) {
call.callStats.setResponseSizeBytes(totalSize);
- call.callStats
- .setCallTimeMs(EnvironmentEdgeManager.currentTime() -
call.callStats.getStartTime());
}
return;
}
- if (responseHeader.hasException()) {
- ExceptionResponse exceptionResponse = responseHeader.getException();
- RemoteException re = createRemoteException(exceptionResponse);
- call.setException(re);
- call.callStats.setResponseSizeBytes(totalSize);
- call.callStats
Review Comment:
Just a refactoring follow the pattern in netty rpc connection. We will set
the callTimeMs in AbstractRpcClient's call method, so we do not need to call
setCallTimeMs here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
