[ 
https://issues.apache.org/jira/browse/HBASE-25051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810261#comment-17810261
 ] 

ASF GitHub Bot commented on HBASE-25051:
----------------------------------------

Apache-HBase commented on PR #5631:
URL: https://github.com/apache/hbase/pull/5631#issuecomment-1907627658

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 15s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m  9s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 44s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 56s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 31s |  root in the patch failed.  |
   | -1 :x: |  compile  |   1m 18s |  hbase-server in the patch failed.  |
   | -0 :warning: |  cc  |   1m 18s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 36s |  hbase-client generated 2 new + 36 
unchanged - 0 fixed = 38 total (was 36)  |
   | -0 :warning: |  javac  |   1m 18s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  checkstyle  |   1m  3s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | -1 :x: |  hadoopcheck  |   1m 47s |  The patch causes 17 errors with 
Hadoop v3.3.6.  |
   | -1 :x: |  hbaseprotoc  |   0m 30s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  spotless  |   0m 39s |  patch has no errors when 
running spotless:check.  |
   | -1 :x: |  spotbugs  |   0m 30s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 26s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  31m 18s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5631 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool |
   | uname | Linux 5b58ca87e360 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3a91c5b698 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | cc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | hadoopcheck | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
 |
   | hbaseprotoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
 |
   | spotbugs | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
 |
   | Max. process+thread count | 81 (vs. ulimit of 30000) |
   | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server 
U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> DIGEST based auth broken for rpc based ConnectionRegistry
> ---------------------------------------------------------
>
>                 Key: HBASE-25051
>                 URL: https://issues.apache.org/jira/browse/HBASE-25051
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, security
>    Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0
>            Reporter: Bharath Vissapragada
>            Assignee: Duo Zhang
>            Priority: Minor
>
> DIGEST-MD5 based sasl auth depends on cluster-ID to obtain tokens. With 
> master registry, we have a circular dependency here because master registry 
> needs an rpcClient to talk to masters (and to get cluster ID) and rpc-Client 
> needs a clusterId if DIGEST based auth is configured. Earlier, there was a ZK 
> client that has its own authentication mechanism to fetch the cluster ID.
> HBASE-23330, I think doesn't fully fix the problem. It depends on an active 
> connection to fetch delegation tokens for the MR job and that inherently 
> assumes that the active connection does not use a DIGEST auth.
> It is not clear to me how common it is to use DIGEST based auth in 
> connections.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to