[ 
https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810531#comment-17810531
 ] 

ASF GitHub Bot commented on HBASE-28313:
----------------------------------------

Apache-HBase commented on PR #5641:
URL: https://github.com/apache/hbase/pull/5641#issuecomment-1908730798

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 20s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 38s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 18s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 16s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 237m 25s |  hbase-server in the patch passed.  
|
   |  |   | 259m 38s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5641 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 462019d83b62 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 354a3a2774 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/testReport/
 |
   | Max. process+thread count | 5202 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5641/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> StorefileRefresherChore should not refresh readonly table
> ---------------------------------------------------------
>
>                 Key: HBASE-28313
>                 URL: https://issues.apache.org/jira/browse/HBASE-28313
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 2.4.17
>            Reporter: Hao Sun
>            Priority: Major
>             Fix For: 2.4.17
>
>
> According to semantics, when StoreFile Refresher is turned on, only the area 
> with replicas should be refreshed. *Tables with read-only attributes will not 
> be refreshed.*
> There are the following scenarios: Assume that some tables in the database 
> have replica enabled, while others do not. If a table that does not have 
> replica enabled needs to perform migration tasks - first enable readonly and 
> then export the snapshot, StorefileRefresherChore will always refresh the 
> table that does not have replica enabled but performs migration tasks. This 
> is obviously illogical.
> Therefore, StorefileRefresherChore needs to determine whether the region has 
> a read-only copy, and refresh it if it has a read-only copy. And tables with 
> read-only properties are not refreshed.
> patch:[HBASE-28313|https://github.com/apache/hbase/pull/5641]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to