[ 
https://issues.apache.org/jira/browse/HBASE-28334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814348#comment-17814348
 ] 

Bryan Beaudreault commented on HBASE-28334:
-------------------------------------------

Thanks [~nirdosh.yadav]. I merged it to master. I'll backport to other branches 
once my branch-2 backport of ERASURE_CODING_POLICY lands.

> Remove unnecessary null DEFAULT_VALUE in TableDescriptorBuilder
> ---------------------------------------------------------------
>
>                 Key: HBASE-28334
>                 URL: https://issues.apache.org/jira/browse/HBASE-28334
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Bryan Beaudreault
>            Assignee: Nirdosh Kumar Yadav
>            Priority: Major
>              Labels: pull-request-available
>
> With ERASURE_CODING_POLICY, the default value is null (no policy). I added a 
> record of that in DEFAULT_VALUES, because other settings seemed to do that.
> A null value is never stored on a HTD because our code handles removing from 
> map when setting null. So we'd never have an opportunity to match against the 
> DEFAULT_VALUE. If someone tried setting a string value "null", that would 
> fail validation because it's not a valid policy. So there's no reason to 
> record this default value. It doesn't cause a problem, but is confusing to 
> anyone reading the code. Remove it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to