kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1487000133
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java:
##########
@@ -70,36 +72,17 @@ protected void createComponents(Configuration conf, HStore
store, CellComparator
}
protected void createCompactor(Configuration conf, HStore store) throws
IOException {
- String className = conf.get(DEFAULT_COMPACTOR_CLASS_KEY,
DEFAULT_COMPACTOR_CLASS.getName());
- try {
- compactor = ReflectionUtils.instantiateWithCustomCtor(className,
- new Class[] { Configuration.class, HStore.class }, new Object[] {
conf, store });
- } catch (Exception e) {
- throw new IOException("Unable to load configured compactor '" +
className + "'", e);
- }
+ createCompactor(conf, store, DEFAULT_COMPACTOR_CLASS_KEY,
DEFAULT_COMPACTOR_CLASS.getName());
}
protected void createCompactionPolicy(Configuration conf, HStore store)
throws IOException {
- String className =
- conf.get(DEFAULT_COMPACTION_POLICY_CLASS_KEY,
DEFAULT_COMPACTION_POLICY_CLASS.getName());
- try {
- compactionPolicy = ReflectionUtils.instantiateWithCustomCtor(className,
- new Class[] { Configuration.class, StoreConfigInformation.class },
- new Object[] { conf, store });
- } catch (Exception e) {
- throw new IOException("Unable to load configured compaction policy '" +
className + "'", e);
- }
+ createCompactionPolicy(conf, store, DEFAULT_COMPACTION_POLICY_CLASS_KEY,
Review Comment:
Adding 1 to the min value when dual file writing is enabled sounds good to
me. If there is no objection for this, I can prepare the change for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
