[ https://issues.apache.org/jira/browse/HBASE-28357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817347#comment-17817347 ]
Hudson commented on HBASE-28357: -------------------------------- Results for branch branch-2 [build #988 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/988/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/988/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/988/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/988/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/988/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} --Failed when running client tests on top of Hadoop 3. [see log for details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/988//artifact/output-integration/hadoop-3.log]. (note that this means we didn't check the Hadoop 3 shaded client) > MoveWithAck#isSuccessfulScan for Region movement should use Region End Key > for limiting scan to one region only. > ---------------------------------------------------------------------------------------------------------------- > > Key: HBASE-28357 > URL: https://issues.apache.org/jira/browse/HBASE-28357 > Project: HBase > Issue Type: Improvement > Components: Region Assignment > Reporter: Mihir Monani > Assignee: Mihir Monani > Priority: Minor > Labels: pull-request-available > Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2 > > > Based on recent learnings and improvements in HBase Canary in HBASE-28204 and > HBASE-28356, I noticed that MoveWithAck.java class also uses similar code to > check that Region is online after region move. > > {code:java} > private void isSuccessfulScan(RegionInfo region) throws IOException { > Scan scan = new > Scan().withStartRow(region.getStartKey()).setRaw(true).setOneRowLimit() > .setMaxResultSize(1L).setCaching(1).setFilter(new > FirstKeyOnlyFilter()).setCacheBlocks(false); {code} > If the region, that was moved, is empty then MoveWithAck#isSuccessfulScan() > will end up scanning next region key space, which is not the intent. If > multiple regions in sequence are empty, then this could create too many > unnecessary scans. By setting withStopRow(endKeyOfRegion, false) for the > scan object, this scan can be bound to only single region. -- This message was sent by Atlassian Jira (v8.20.10#820010)