rmdmattingly commented on code in PR #5683:
URL: https://github.com/apache/hbase/pull/5683#discussion_r1493805682


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##########
@@ -131,7 +131,8 @@ public void close() {
 
   @Override
   public long getReadAvailable() {
-    return readAvailable;
+    // at this point we've grabbed some quota, so we should use at least that
+    return Math.max(readAvailable, readConsumed);

Review Comment:
   I see both sides. I think it's ok for us to be more specific with the naming 
here because, like you said, the current usage scope is small enough for us to 
be specific



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to