Apache9 commented on code in PR #5706:
URL: https://github.com/apache/hbase/pull/5706#discussion_r1501766068
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:
##########
@@ -800,7 +800,12 @@ public int onlineHbck()
checkRegionBoundaries();
}
- checkAndFixReplication();
+ TableName hbaseReplicationTable =
+
TableName.valueOf(getConf().get(ReplicationStorageFactory.REPLICATION_QUEUE_TABLE_NAME,
+
ReplicationStorageFactory.REPLICATION_QUEUE_TABLE_NAME_DEFAULT.getNameAsString()));
+ if (admin.tableExists(hbaseReplicationTable)) {
Review Comment:
The ReplicationQueueStorage has a hasData method. I think we'd better make
use of it.
I think we can introduce a should check method for ReplicationChecker class
and call it in checkAndFixReplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
