frostruan commented on PR #5699:
URL: https://github.com/apache/hbase/pull/5699#issuecomment-1966711401

   > 1. If it held 1, it would mean that regions that no longer exist would 
still get reported with size (maybe?)
   
   I don't think regions in state transition and regions no longer exist are 
same thing. When we call regionLocator.getAllRegionLocations(), we will exlcude 
offlined split parent regions. You can see 
https://github.com/apache/hbase/blob/rel/3.0.0-beta-1/hbase-client/src/main/java/org/apache/hadoop/hbase/ClientMetaTableAccessor.java#L172
 for details.
   
   2. I don't think it is appropriate to return the average size of other 
regions, we should not make any decisions for the user.
   
   > 3. What if there are currently no regions available? 
   
   I don't think this is a big deal. As @ndimiduk mentioned, it's just a hint 
for MapReduce scheduler. 
   
   Thanks. @aalhour 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to