ndimiduk commented on code in PR #5736: URL: https://github.com/apache/hbase/pull/5736#discussion_r1508811116
########## dev-support/create-release/release-util.sh: ########## @@ -613,6 +613,8 @@ function update_releasenotes { else mv "${releasenotes}" "${project_dir}/RELEASENOTES.md" fi + log "${MVN[@]}" spotless:apply -DspotlessFiles='RELEASENOTES*.md,CHANGES*.md' Review Comment: Hmm. Re-reading this function, it looks like we move the files into project_dir, whether there's managed in git or not. project_dir is the git checkout, isn't it? so then this should be fine for either style or management. Anyway, let me try it in dry-run on a couple branches and projects and see how it goes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org