stoty commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1974357734
Curator can be simpler whan used to implement some of the more advanced synchronization constructs. In this case all we do is read and watch a simple value, and I would argue that my version is easier to read than the curator one, as it has one a few less levels of redirection and abstraction, and does not need familiarity with Curator. We can also save a few lines by moving the Znode creation into the test, which would make more sense anyway, as it is supposed to be set by an external service. The only real advantage of using Curator here is that it should handle the loss of ZK connection better, which is relevant if we intend this as drop-in production feature, but not as an API example. In general I like the idea of not shipping the examples JAR in the assembly. I recall using it once to test REST server connectivity, but in general I think the advanatages outweigh the possible inconvenience (it can still be downloaded from maven) If we keep curator and remove examples from the assembly, I would go one step further, and also the version management for curator, and only add it in examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
