[ 
https://issues.apache.org/jira/browse/HBASE-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419561#comment-13419561
 ] 

Zhihong Ted Yu commented on HBASE-6433:
---------------------------------------

Looking at the code, Connection has this member:
{code}
    private InetAddress addr;
{code}
But I don't see where it is assigned. The following assignment is to a local 
variable:
{code}
      InetAddress addr = socket.getInetAddress();
{code}
                
> Improve HBaseServer#getRemoteAddress by utilizing 
> HBaseServer.Connection.hostAddress
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-6433
>                 URL: https://issues.apache.org/jira/browse/HBASE-6433
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 6433-getRemoteAddress-trunk.txt, HBASE-6433-90.patch, 
> HBASE-6433-92.patch, HBASE-6433-94.patch, HBASE-6433-trunk.patch
>
>
> Currently, HBaseServer#getRemoteAddress would call getRemoteIp(), leading to 
> call.connection.socket.getInetAddress().
> The host address is actually stored in HBaseServer.Connection.hostAddress 
> field. We don't need to go through Socket to get this information.
> Without this patch it costs 4000ns, with this patch it costs 1600ns

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to