ndimiduk commented on code in PR #5745:
URL: https://github.com/apache/hbase/pull/5745#discussion_r1515875061
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java:
##########
@@ -250,12 +250,12 @@ private static void applyClusterKeyToConf(Configuration
conf, String key) throws
conf.set(HConstants.ZOOKEEPER_ZNODE_PARENT, zkClusterKey.getZnodeParent());
// Without the right registry, the above configs are useless. Also, we
don't use setClass()
// here because the ConnectionRegistry* classes are not resolvable from
this module.
- // This will be broken if ZkConnectionRegistry class gets renamed or
moved. Is there a better
- // way?
- LOG.info("Overriding client registry implementation to {}",
- HConstants.ZK_CONNECTION_REGISTRY_CLASS);
- conf.set(HConstants.CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY,
- HConstants.ZK_CONNECTION_REGISTRY_CLASS);
+ // This will be broken if ZkConnectionRegistryInternal class gets renamed
or moved. Is there
+ // a better way?
+ String ZKConnectionRegistryClass =
+ "org.apache.hadoop.hbase.client.ZKConnectionRegistryInternal";
+ LOG.info("Overriding client registry implementation to {}",
ZKConnectionRegistryClass);
Review Comment:
Hmm you're right. I miss-understood the use of this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
