[ 
https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420266#comment-13420266
 ] 

Jesse Yates commented on HBASE-5547:
------------------------------------

{quote}
Users may choose to enable the combination of cleaners shown in the current 
TestZooKeeperTableArchiveClient.
We should verify that this combination works.
{quote}

I'd argue that we have verified by inspection. Using the time-based waiting on 
the cluster tends to lead to flapping tests (e.g. the original error), which is 
bad. Because the cleaner chain works, the TTL cleaner works (both of which are 
tested) and the zk archiver cleaner works, we can then say that they work 
together.
                
> Don't delete HFiles when in "backup mode"
> -----------------------------------------
>
>                 Key: HBASE-5547
>                 URL: https://issues.apache.org/jira/browse/HBASE-5547
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>            Assignee: Jesse Yates
>             Fix For: 0.96.0, 0.94.2
>
>         Attachments: 5547-v12.txt, 5547-v16.txt, hbase-5447-v8.patch, 
> hbase-5447-v8.patch, hbase-5547-v9.patch, java_HBASE-5547.addendum, 
> java_HBASE-5547_v13.patch, java_HBASE-5547_v14.patch, 
> java_HBASE-5547_v15.patch, java_HBASE-5547_v4.patch, 
> java_HBASE-5547_v5.patch, java_HBASE-5547_v6.patch, java_HBASE-5547_v7.patch
>
>
> This came up in a discussion I had with Stack.
> It would be nice if HBase could be notified that a backup is in progress (via 
> a znode for example) and in that case either:
> 1. rename HFiles to be delete to <file>.bck
> 2. rename the HFiles into a special directory
> 3. rename them to a general trash directory (which would not need to be tied 
> to backup mode).
> That way it should be able to get a consistent backup based on HFiles (HDFS 
> snapshots or hard links would be better options here, but we do not have 
> those).
> #1 makes cleanup a bit harder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to