kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1545464762
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java:
##########
@@ -138,6 +140,12 @@ public class HStoreFile implements StoreFile {
// Indicates if the file got compacted
private volatile boolean compactedAway = false;
+ // Indicate if the file contains historical cell versions. This is used when
+ // hbase.enable.historical.compaction.files is set to true. In that case,
compactions
+ // can generate two files, one with the live cell versions and the other
with the remaining
+ // (historical) cell versions.
+ private volatile boolean isHistorical = false;
Review Comment:
It looks like I need to add more comments for this. If isHistorical is true
then the hfile is historical. Historical files are skipped for regular (not
raw) scans scanning latest row versions. When
hbase.enable.historical.compaction.files is false, the historical flag will be
false for all files. This means all files will be treated as live files, and
thus there is no need to track them. Historical files are generated only when
hbase.enable.historical.compaction.files is true. Only when
hbase.enable.historical.compaction.files is true, we enable live file file
tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
