[ https://issues.apache.org/jira/browse/HBASE-28460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833730#comment-17833730 ]
Hudson commented on HBASE-28460: -------------------------------- Results for branch branch-3 [build #176 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/176/]: (/) *{color:green}+1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/176/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/176/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/176/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Full backup restore fails for empty HFiles > ------------------------------------------ > > Key: HBASE-28460 > URL: https://issues.apache.org/jira/browse/HBASE-28460 > Project: HBase > Issue Type: Bug > Components: backup&restore > Reporter: Dieter De Paepe > Assignee: Dieter De Paepe > Priority: Major > Labels: pull-request-available > Fix For: 2.6.0, 3.0.0-beta-2 > > > A full backup restore fails if the backup contains an empty HFile, for > example when all data has been deleted from a table and full compaction has > run. There are several issues: > * HFiles are read in `RestoreTool` to read the first/last key, but this > fails for empty HFiles > * In `RestoreTool`, table creation also incorrectly assumes the region > contains keys > * In `MapReduceRestoreJob`, the tool incorrectly assumes that a bulkload > with no loaded entries is an error. > Example stacktrace: > {code:java} > 24/03/21 18:38:09 ERROR org.apache.hadoop.hbase.backup.util.BackupUtils: > java.util.NoSuchElementException: No value present > java.util.NoSuchElementException: No value present > at java.base/java.util.Optional.get(Optional.java:143) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.generateBoundaryKeys(RestoreTool.java:440) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.checkAndCreateTable(RestoreTool.java:493) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:351) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.fullRestoreTable(RestoreTool.java:211) > at > org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:151) > at > org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229) > at > org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265) > at > org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518) > at > org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176) > at > org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216) > at > org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) > at > org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224) > 24/03/21 18:38:09 ERROR org.apache.hadoop.hbase.backup.RestoreDriver: Error > while running restore backup > java.lang.IllegalStateException: Cannot restore hbase table > at > org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:360) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.fullRestoreTable(RestoreTool.java:211) > at > org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:151) > at > org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229) > at > org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265) > at > org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518) > at > org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176) > at > org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216) > at > org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) > at > org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224) > Caused by: java.util.NoSuchElementException: No value present > at java.base/java.util.Optional.get(Optional.java:143) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.generateBoundaryKeys(RestoreTool.java:440) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.checkAndCreateTable(RestoreTool.java:493) > at > org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:351) > ... 10 more {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)