[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835607#comment-17835607 ]
Hudson commented on HBASE-28485: -------------------------------- Results for branch branch-2.6 [build #91 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/91/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/91/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/91/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/91/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/91/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Re-use ZstdDecompressCtx/ZstdCompressCtx for performance > -------------------------------------------------------- > > Key: HBASE-28485 > URL: https://issues.apache.org/jira/browse/HBASE-28485 > Project: HBase > Issue Type: Improvement > Reporter: Charles Connell > Assignee: Charles Connell > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9 > > Attachments: async-prof-flamegraph-cpu_event-1712150670836-cpu.html, > async-prof-pid-1324144-cpu-1.html > > > The zstd documentation > [recommends|https://facebook.github.io/zstd/zstd_manual.html#Chapter4] > re-using context objects when possible, because their creation has some > expense. They can be more cheaply reset than re-created. In > {{ZstdDecompressor}} and {{{}ZstdCompressor{}}}, we create a new context > object for every call to {{decompress()}} and {{{}compress(){}}}. In CPU > profiles I've taken at my company, the constructor of {{ZstdDecompressCtx}} > can sometimes represent 10-25% of the time spent in zstd decompression, which > itself is 5-10% of a RegionServer's total CPU time. Avoiding this performance > penalty won't lead to any massive performance boost, but is a nice little win. -- This message was sent by Atlassian Jira (v8.20.10#820010)