Apache9 commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1558961072
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java:
##########
@@ -181,7 +197,10 @@ public long getPos() throws IOException {
*/
public void appendMetadata(final long maxSequenceId, final boolean
majorCompaction)
throws IOException {
- appendMetadata(maxSequenceId, majorCompaction, Collections.emptySet());
+ liveFileWriter.appendMetadata(maxSequenceId, majorCompaction);
Review Comment:
OK, checked the other multi file writer implementation, found HBASE-15400,
where we explained why we use the same maxSequenceId for multiple genedated
store files. So at least this is not a critical problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
