kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2074180292
> There is only one blocker, about the concurrency control. We'd better still hold the consistent view while getting storefile list. > > The other is not a blocker but still better to make it clear that whether we will throw any exception for some storefile management operations. > > Thanks. @Apache9, I made the requested changes for having consistent view while getting store files. I also took the liberty to rename storefiles to storeFiles and getStorefiles() to getStoreFiles(). The hfile reader throws IOException. DefaultStoreFileManager reads the file metadata during loading the files to see which of the loaded files are live (since DefaultStoreFileManager maintains a separate list for live files). Therefore, I had to change the method signature. Thank you for review again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
