jhungund commented on code in PR #5856:
URL: https://github.com/apache/hbase/pull/5856#discussion_r1583445711
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java:
##########
@@ -61,25 +63,25 @@ private DataTieringManager(Map<String, HRegion>
onlineRegions) {
* Initializes the DataTieringManager instance with the provided map of
online regions.
* @param onlineRegions A map containing online regions.
*/
- public static synchronized void instantiate(Map<String, HRegion>
onlineRegions) {
- if (instance == null) {
- instance = new DataTieringManager(onlineRegions);
- LOG.info("DataTieringManager instantiated successfully.");
+ public static synchronized void instantiate(Configuration conf,
Review Comment:
I have made the function isDataTieringFeatureEnabled private function of the
class. We do not want to give the undue flexiblity to the user to instantiate
the DataTieringManager even when the feature key is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
