gvprathyusha6 commented on code in PR #5307:
URL: https://github.com/apache/hbase/pull/5307#discussion_r1595450504
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java:
##########
@@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) {
}
@Override
- boolean testRow(final int i, final long startTime) throws IOException {
+ protected boolean testRow(final int i, final long startTime) throws
IOException {
Review Comment:
to override this in impl class, so that we can customise row format. If the
custom test knows the dataset, it would be beneficial to repro any specific
scenario, like if I have the rowkey similar to what tsdb puts, I can create
scan load on particular dataset and write load on another and try to get closer
to prod scenarios
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
