DieterDP-ng commented on code in PR #5871:
URL: https://github.com/apache/hbase/pull/5871#discussion_r1598573660
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java:
##########
@@ -102,24 +95,6 @@ public static Path getTableBackupPath(TableName tableName,
Path backupRootPath,
return new Path(getTableBackupDir(backupRootPath.toString(), backupId,
tableName));
}
- /**
- * Given the backup root dir and the backup id, return the log file location
for an incremental
- * backup.
- * @param backupRootDir backup root directory
- * @param backupId backup id
- * @return logBackupDir: ".../user/biadmin/backup/WALs/backup_1396650096738"
- */
- public static String getLogBackupDir(String backupRootDir, String backupId) {
- return backupRootDir + Path.SEPARATOR + backupId + Path.SEPARATOR
- + HConstants.HREGION_LOGDIR_NAME;
- }
-
- public static Path getLogBackupPath(String backupRootDir, String backupId) {
- return new Path(getLogBackupDir(backupRootDir, backupId));
- }
-
- // TODO we do not keep WAL files anymore
Review Comment:
My interpretation of this TODO (introduced in HBASE-14135), is that it was
already implemented in that same commit. If that weren't the case, the TODO
message is too vague for me to understand what needs to be done, rendering it
useless anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
