Apache9 commented on code in PR #5865:
URL: https://github.com/apache/hbase/pull/5865#discussion_r1604720569
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReservoirSample.java:
##########
@@ -41,7 +41,7 @@ public class ReservoirSample<T> {
private int n;
public ReservoirSample(int k) {
- Preconditions.checkArgument(k > 0, "negative sampling number(%d) is not
allowed");
+ Preconditions.checkArgument(k > 0, "negative sampling number(%s) is not
allowed", k);
Review Comment:
Not only checkstyle, if there are errors the output is incorrect...
Maybe we should file an issue to apply this to all branches.
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplication.java:
##########
@@ -86,6 +86,14 @@ public class TestVerifyReplication extends
TestReplicationBase {
@Rule
public TestName name = new TestName();
+ @Override
+ protected String getClusterKey(HBaseTestingUtil util) throws Exception {
+ // TODO: VerifyReplication does not support connection uri yet, so here we
need to use cluster
Review Comment:
HBASE-28565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
