vinayakphegde commented on code in PR #5866:
URL: https://github.com/apache/hbase/pull/5866#discussion_r1604901642
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -2203,6 +2204,18 @@ public Optional<Boolean> shouldCacheFile(HFileInfo
hFileInfo, Configuration conf
return Optional.of(!fullyCachedFiles.containsKey(fileName));
}
+ @Override
+ public Optional<Boolean> shouldCacheBlock(BlockCacheKey key,
TimeRangeTracker timeRangeTracker,
+ Configuration conf) {
+ DataTieringManager dataTieringManager = DataTieringManager.getInstance();
+ if (dataTieringManager != null &&
!dataTieringManager.isHotData(timeRangeTracker, conf)) {
+ LOG.debug("Data tiering is enabled for file: '{}' and it is not hot
data",
+ key.getHfileName());
Review Comment:
Currently, it's only used for logging purposes. The caller function,
shouldCacheBlock(), isn't aware of data tiering, so I couldn't add that line
there. Hence, I kept it here. Additionally, it makes sense to pass the
corresponding BlockCacheKey to shouldCacheBlock() to make the decision.
However, I'm okay with removing that parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
