Apache9 commented on code in PR #5906:
URL: https://github.com/apache/hbase/pull/5906#discussion_r1606451196
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1336,7 +1341,7 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
return cachedBlock;
}
- if (!useLock && cacheable &&
cacheConf.shouldLockOnCacheMiss(expectedBlockType)) {
+ if (!useLock && cacheBlock &&
cacheConf.shouldLockOnCacheMiss(expectedBlockType)) {
Review Comment:
Why we have this change?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -560,6 +564,21 @@ protected void cacheBlockWithWaitInternal(BlockCacheKey
cacheKey, Cacheable cach
}
}
+ public BucketEntry getBlockForReference(BlockCacheKey key) {
Review Comment:
Mind explaining a bit what is the usage for this method? And add some
comments? Does this method needs to be public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
