[ https://issues.apache.org/jira/browse/HBASE-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424561#comment-13424561 ]
Zhihong Ted Yu commented on HBASE-6429: --------------------------------------- {code} + * This is a Filter wrapper class which is used in the server side. Some filter + * related hooks can be defined in this wrapper. The only way to create a + * FilterWrapper instance is passing a client side Filter instance. {code} To help users make sense of the third sentence, explanation should be added as to how client Filter instance is obtained by server (through Scan object). {code} + throw new NullPointerException("Cannot create FilterWrapper with null"); {code} 'with null' -> 'with null Filter' {code} + //2. Here to merge the filterRow() into filterRow(kvs), {code} Rephrase the above: filterRow() is merged with filterRow(kvs) {code} - private Filter filter; + private FilterWrapper filter; {code} There is no need to change the type of filter - FilterWrapper doesn't add new methods. {code} + "Filter hasFilterRow incompatible with scan with limit!"); {code} Rephrase the above: 'Filter whose hasFilterRow() returns true is ' {code} + } else { + LOG.error("HBaseAdmin is not initialized successfully."); + } {code} The above condition should result in test failure, right ? {code} + } catch (IOException e) { + e.printStackTrace(); + assertNull("Exception found deleting the table", e); + } {code} Since exception is part of the assertion, e.printStackTrace() is redundant. Please remove the call. {code} + * To test if the FilterWrapper keeps the same semantics {code} The above sentence seems incomplete. {code} + // no correct result is expected + LOG.info("Exception is catched"); + assertNull("Exception happens in scan", e); {code} Spelling mistake in the log statement. Since exception is part of assertion, the log is redundant. Suggest removing the log statement. {code} + } catch (IOException e) { + e.printStackTrace(); + assertNull("Exception found deleting the table", e); + } {code} Please remove e.printStackTrace() call. > Filter with filterRow() returning true is incompatible with scan with limit > --------------------------------------------------------------------------- > > Key: HBASE-6429 > URL: https://issues.apache.org/jira/browse/HBASE-6429 > Project: HBase > Issue Type: Bug > Components: filters > Affects Versions: 0.96.0 > Reporter: Jason Dai > Attachments: hbase-6429-trunk-v2.patch, hbase-6429-trunk.patch, > hbase-6429_0_94_0.patch > > > Currently if we scan with bot limit and a Filter with > filterRow(List<KeyValue>) implemented, an IncompatibleFilterException will > be thrown. The same exception should also be thrown if the filer has its > filterRow() implemented. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira