[ 
https://issues.apache.org/jira/browse/HBASE-28401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867221#comment-17867221
 ] 

Ujjawal Kumar edited comment on HBASE-28401 at 7/19/24 7:39 AM:
----------------------------------------------------------------

[~zhangduo] [~vjasani] Looks like this change has introduced regression in 
other tooling. Ref 
 # HBASE-28743 - Snapshot based mapreduce jobs fails with NPE while trying to 
close mslab within mapper

 # HBASE-28742 - CompactionTool fails with NPE when mslab is enabled


was (Author: ukumar):
[~zhangduo] [~vjasani] Looks like this has introduced regression in other 
tooling. Ref 
 # HBASE-28743 - Snapshot based mapreduce jobs fails with NPE while trying to 
close mslab within mapper

 # HBASE-28742 - CompactionTool fails with NPE when mslab is enabled

> Introduce a close method for memstore for release active segment
> ----------------------------------------------------------------
>
>                 Key: HBASE-28401
>                 URL: https://issues.apache.org/jira/browse/HBASE-28401
>             Project: HBase
>          Issue Type: Sub-task
>          Components: in-memory-compaction, regionserver
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.6.0, 3.0.0-beta-2, 2.5.9
>
>
> Per the analysis in parent issue, we will always have an active segment in 
> memstore even if it is empty, so if we do not call close on it, it will lead 
> to a netty leak warning message.
> Although there is no real memory leak for this case, we'd better still fix it 
> as it may hide other memory leak problem.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to