ndimiduk commented on code in PR #6096:
URL: https://github.com/apache/hbase/pull/6096#discussion_r1686364380
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaRetriever.java:
##########
@@ -55,19 +55,29 @@ public class QuotaRetriever implements Closeable,
Iterable<QuotaSettings> {
/**
* Should QutoaRetriever manage the state of the connection, or leave it be.
*/
- private boolean isManagedConnection = false;
+ private final boolean isManagedConnection;
- QuotaRetriever() {
+ public QuotaRetriever(final Connection conn) throws IOException {
+ this(conn, (QuotaFilter) null);
Review Comment:
I believe it is required. Without it, Java won't know which version of the
two-arg constructor to call -- there are two variants that have `Connection` as
the first argument. Indeed, IntelliJ complains when I remove this cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
