Apache9 commented on code in PR #6109:
URL: https://github.com/apache/hbase/pull/6109#discussion_r1689019089
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionTool.java:
##########
@@ -97,4 +112,32 @@ private void putAndFlush(int key) throws Exception {
region.flush(true);
}
+ @Test
+ public void testCompactedFilesArchivedMapRed() throws Exception {
+ for (int i = 0; i < 10; i++) {
+ this.putAndFlush(i);
+ }
+ HStore store = region.getStore(HBaseTestingUtility.fam1);
+ assertEquals(10, store.getStorefilesCount());
+ Path tableDir = CommonFSUtils.getTableDir(rootDir,
region.getRegionInfo().getTable());
+ FileSystem fs = store.getFileSystem();
+ String storePath = tableDir + "/" +
region.getRegionInfo().getEncodedName() + "/"
+ + Bytes.toString(HBaseTestingUtility.fam1);
+ FileStatus[] regionDirFiles = fs.listStatus(new Path(storePath));
+ assertEquals(10, regionDirFiles.length);
+ String defaultFS =
testUtil.getMiniHBaseCluster().getConfiguration().get("fs.defaultFS");
+ testUtil.startMiniMapReduceCluster();
+ try {
+ Configuration config =
HBaseConfiguration.create(testUtil.getConfiguration());
+ config.setBoolean(MemStoreLAB.USEMSLAB_KEY, true);
Review Comment:
I do not get the point here...
We will run the test method twice with USEMSLAB_KEY as true and false, so we
can cover the scenario where we pass USEMSLAB_KEY as true? If we only want it
to be true, we should give this test method a separated test class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
