ranganathg commented on code in PR #6179:
URL: https://github.com/apache/hbase/pull/6179#discussion_r1751330643


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java:
##########
@@ -393,6 +393,8 @@ protected void doReplaceWriter(Path oldPath, Path newPath, 
Writer nextWriter) th
             inflightWALClosures.remove(oldPath.getName());
             if (!isUnflushedEntries()) {
               markClosedAndClean(oldPath);
+            } else {
+              LOG.debug("WAL has unflushed entries path: " + oldPath);

Review Comment:
   Should you add some metrics to track this event? Is this PR about adding 
logs to help debugging? is there more to the fix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to