NihalJain commented on code in PR #6249: URL: https://github.com/apache/hbase/pull/6249#discussion_r1762875881
########## hbase-common/src/test/java/org/apache/hadoop/hbase/util/RandomDistributionCopy.java: ########## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.util; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Random; + +/** + * A class that generates random numbers that follow some distribution. + * <p> + * Copied from <a href="https://issues.apache.org/jira/browse/HADOOP-3315";>hadoop-3315 tfile</a>. + * Remove after tfile is committed and use the tfile version of this class instead. + * </p> + */ +public class RandomDistributionCopy { Review Comment: > Can't we just move this from hbase-compression to hbase-common with the same name ? I am +1 on moving to hbase-common. Will wait some time before updating draft with this change, lets also see what other think about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
