[ 
https://issues.apache.org/jira/browse/HBASE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427581#comment-13427581
 ] 

Zhihong Ted Yu commented on HBASE-6481:
---------------------------------------

Test failures are not related to the patch.
Will integrate tomorrow if there is no objection.
                
> SkipFilter javadoc is incorrect
> -------------------------------
>
>                 Key: HBASE-6481
>                 URL: https://issues.apache.org/jira/browse/HBASE-6481
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0
>            Reporter: Shrijeet Paliwal
>            Priority: Minor
>              Labels: newbie
>         Attachments: 0001-HBASE-6481-SkipFilter-javadoc-is-incorrect.patch
>
>
> The javadoc for SkipFilter 
> (http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/SkipFilter.html)
>  states : 
>  
> A wrapper filter that filters an entire row if any of the KeyValue checks do 
> not pass.
>  
> But the example same javadocs gives to support this statement is wrong. The 
> *scan.setFilter(new SkipFilter(new ValueFilter(CompareOp.EQUAL,
>      new BinaryComparator(Bytes.toBytes(0))));* , will only emit rows which 
> have all column values zero. In other words it is going to skip all rows for 
> which 
> ValueFilter(CompareOp.EQUAL, new BinaryComparator(Bytes.toBytes(0))) does not 
> pass , which happen to be all non zero valued cells. 
> In the same example a ValueFilter created with CompareOp.NOT_EQUAL will 
> filter out the rows which have a column value zero. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to