[
https://issues.apache.org/jira/browse/HBASE-28771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887674#comment-17887674
]
Daniel Roudnitsky commented on HBASE-28771:
-------------------------------------------
[~ndimiduk] yes I don't think its needed , one could use isActionComplete with
the change proposed here for non replica actions which have a non-null result
array (replica actions always have result array so it works in its current
form), but I originally proposed this change so I could reuse the method for
HBASE-27781 (which I am hoping to get reviews on :)) but since that work has to
be able to handle AsyncRequestFutures with null result array I wasn't able to
use something like isActionComplete which relies on the existence of a result
array, so I withdrew this issue/PR.
> Add support for non replica actions to AsyncRequestFutureImpl.isActionComplete
> ------------------------------------------------------------------------------
>
> Key: HBASE-28771
> URL: https://issues.apache.org/jira/browse/HBASE-28771
> Project: HBase
> Issue Type: Task
> Components: Client
> Affects Versions: 2.6.0, 2.5.10
> Reporter: Daniel Roudnitsky
> Assignee: Daniel Roudnitsky
> Priority: Minor
> Labels: pull-request-available
>
> The current isActionComplete method we have in AsyncRequestFutureImpl is only
> designed to support replica actions, it would be useful to have
> isActionComplete support non replica actions that could be reused for
> HBASE-27781 / [#6144|https://github.com/apache/hbase/pull/6144/files] and in
> other paths where non replica actions are being handled.
> Since isActionComplete currently only has one caller we can move the replica
> action check to the caller method instead of having the check be inside
> isActionComplete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
