[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428562#comment-13428562
]
Andrew Purtell edited comment on HBASE-6505 at 8/4/12 5:24 AM:
---------------------------------------------------------------
bq. So I should probably key that map with a String (which would
Class.getName()).
Makes sense.
bq. When an Environment is blacklisted, it is only that environment, is it then
safe to remove the classes part from the sharedDataMap (since there might be
other instance of the same class, but loaded from a different class loader).
Thinking on this, perhaps we can defer that until CPs can actually be unloaded.
Blacklisting is only a half measure. If I've seen in an RS log that a CP has
been blacklisted my thinking is it's time to cycle the RS. Who knows what
damage has been done. And attempts to limit heap usage of the map don't make
much sense IMO for the same reason, the CP could leak objects directly.
Edit: But if you agree, would be good to include a comment to this effect near
the map.
was (Author: apurtell):
bq. So I should probably key that map with a String (which would
Class.getName()).
Makes sense.
bq. When an Environment is blacklisted, it is only that environment, is it then
safe to remove the classes part from the sharedDataMap (since there might be
other instance of the same class, but loaded from a different class loader).
Thinking on this, perhaps we can defer that until CPs can actually be unloaded.
Blacklisting is only a half measure. If I've seen in an RS log that a CP has
been blacklisted my thinking is it's time to cycle the RS. Who knows what
damage has been done. And attempts to limit heap usage of the map don't make
much sense IMO for the same reason, the CP could leak objects directly.
> Investigate shared RegionObserver state
> ---------------------------------------
>
> Key: HBASE-6505
> URL: https://issues.apache.org/jira/browse/HBASE-6505
> Project: HBase
> Issue Type: Sub-task
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6505-v2.txt, 6505.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
