stoty commented on code in PR #6388:
URL: https://github.com/apache/hbase/pull/6388#discussion_r1816105804
##########
hbase-server/pom.xml:
##########
@@ -437,24 +438,83 @@
<skipAssembly>true</skipAssembly>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>add-test-source</id>
+ <goals>
+ <goal>add-test-resource</goal>
+ </goals>
+ <phase>generate-test-sources</phase>
+ <configuration>
+ <!-- Add the hbase-webapps directory to the test resources -->
+ <resources>
+ <resource>
+ <!-- Directory containing hbase-webapps -->
+ <directory>target/${hbase.webapps.dir}</directory>
+ <!-- Target directory under test-classes -->
+ <targetPath>${hbase.webapps.dir}</targetPath>
Review Comment:
I meant the source directory: We cannot ass the source directory directly,
because we need the .JSP files compiled first, right ?
##########
hbase-server/pom.xml:
##########
@@ -437,24 +438,83 @@
<skipAssembly>true</skipAssembly>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>add-test-source</id>
+ <goals>
+ <goal>add-test-resource</goal>
+ </goals>
+ <phase>generate-test-sources</phase>
+ <configuration>
+ <!-- Add the hbase-webapps directory to the test resources -->
+ <resources>
+ <resource>
+ <!-- Directory containing hbase-webapps -->
+ <directory>target/${hbase.webapps.dir}</directory>
+ <!-- Target directory under test-classes -->
+ <targetPath>${hbase.webapps.dir}</targetPath>
Review Comment:
I meant the source directory: We cannot add the source directory directly,
because we need the .JSP files compiled first, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
