[ https://issues.apache.org/jira/browse/HBASE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429330#comment-13429330 ]
Hadoop QA commented on HBASE-5189: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538254/HBASE-5189-persistent.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2521//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2521//console This message is automatically generated. > Add metrics to keep track of region-splits in RS > ------------------------------------------------ > > Key: HBASE-5189 > URL: https://issues.apache.org/jira/browse/HBASE-5189 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver > Affects Versions: 0.90.5, 0.92.0 > Reporter: Mubarak Seyed > Assignee: Mubarak Seyed > Priority: Minor > Labels: noob > Fix For: 0.94.0 > > Attachments: HBASE-5189-persistent.patch, HBASE-5189.trunk.v1.patch, > HBASE-5189.trunk.v2.patch > > > For write-heavy workload with region-size 1 GB, region-split is considerably > high. We do normally grep the NN log (grep "mkdir*.split" NN.log | sort | > uniq -c) to get the count. > I would like to have a counter incremented each time region-split execution > succeeds and this counter exposed via the metrics stuff in HBase. > - regionSplitSuccessCount > - regionSplitFailureCount (will help us to correlate the timestamp range in > RS logs across all RS) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira