ndimiduk commented on code in PR #6495:
URL: https://github.com/apache/hbase/pull/6495#discussion_r1867634666
##########
bin/hbase:
##########
@@ -804,9 +804,10 @@ fi
HEAP_SETTINGS="$JAVA_HEAP_MAX $JAVA_OFFHEAP_MAX"
# by now if we're running a command it means we need logging
+# prepend the logging jars to make sure they are before the ones coming from
HADOOP_CLASSPATH
for f in ${HBASE_HOME}/lib/client-facing-thirdparty/log4j*.jar; do
if [ -f "${f}" ]; then
- CLASSPATH="${CLASSPATH}:${f}"
+ CLASSPATH="${f}:${CLASSPATH}"
Review Comment:
_shudder_
Nice one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
