stoty commented on code in PR #6520:
URL: https://github.com/apache/hbase/pull/6520#discussion_r1870750400
##########
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java:
##########
@@ -139,6 +139,9 @@ public TableScanResource getScanResource(final
@PathParam("scanspec") String sca
@DefaultValue("true") @QueryParam(Constants.SCAN_INCLUDE_START_ROW)
boolean includeStartRow,
@DefaultValue("false") @QueryParam(Constants.SCAN_INCLUDE_STOP_ROW)
boolean includeStopRow) {
try {
+ if (servlet.getAdmin().isTableDisabled(TableName.valueOf(this.table))) {
+ throw new ServiceUnavailableException("Table disabled.");
Review Comment:
I am worried that this explicit check may cause some extra network traffic.
Can we catch whatever exception HBase throws in this case, and process that ?
Also, the same check applies to most operations, so we should probably check
this on all non-metadata endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
