[ 
https://issues.apache.org/jira/browse/HBASE-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431984#comment-13431984
 ] 

Zhihong Ted Yu commented on HBASE-6529:
---------------------------------------

Looking at HFileSystem closer, I don't see the case of HFileSystem being cached 
in FileSystem.Cache.
So srcPath.getFileSystem(conf) wouldn't return an HFileSystem instance.

This explains why the following check would always be true (fs being an 
HFileSystem instance):
{code}
    if (!srcFs.equals(fs)) {
{code}
I searched through FilterFileSystem and FileSystem source code. They don't 
implement equals() method for instance of FileSystem or FilterFileSystem.
Meaning, identity equality is used in the above check.
                
> With HFile v2, the region server will always perform an extra copy of source 
> files
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-6529
>                 URL: https://issues.apache.org/jira/browse/HBASE-6529
>             Project: HBase
>          Issue Type: Bug
>          Components: performance, regionserver
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jason Dai
>         Attachments: hbase-6529.diff
>
>
> With HFile v2 implementation in HBase 0.94 & 0.96, the region server will use 
> HFileSystem as its {color:blue}fs{color}. When it performs bulk load in 
> Store.bulkLoadHFile(), it checks if its {color:blue}fs{color} is the same as 
> {color:blue}srcFs{color}, which however will be DistributedFileSystem. 
> Consequently, it will always perform an extra copy of source files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to