NihalJain commented on code in PR #6585:
URL: https://github.com/apache/hbase/pull/6585#discussion_r1908751337
##########
hbase-server/src/main/resources/hbase-webapps/master/snapshotsStats.jsp:
##########
@@ -99,18 +99,18 @@
<td>
<%= SnapshotDescriptionUtils.isExpiredSnapshot(snapshotDesc.getTtl(),
snapshotDesc.getCreationTime(), System.currentTimeMillis()) ? "Yes" : "No" %>
</td>
- <td><%= StringUtils.humanReadableInt(stats.getSharedStoreFilesSize())
%></td>
- <td><%= StringUtils.humanReadableInt(stats.getMobStoreFilesSize())
%></td>
- <td><%= StringUtils.humanReadableInt(stats.getArchivedStoreFileSize()) %>
- (<%=
StringUtils.humanReadableInt(stats.getNonSharedArchivedStoreFilesSize())
%>)</td>
+ <td><%=
StringUtils.TraditionalBinaryPrefix.long2String(stats.getSharedStoreFilesSize(),
"", 1) %></td>
Review Comment:
NIT: Somehow I don't like the new method / its name / params. It is very
cryptic. May be just add a wrapper method in this class? It's upto you though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
