charlesconnell commented on code in PR #6596:
URL: https://github.com/apache/hbase/pull/6596#discussion_r1912063145
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java:
##########
@@ -314,10 +314,16 @@ public interface MetricsRegionServerSource extends
BaseSource, JvmPauseMonitorSo
"Size of data that has been sent by clients with the write ahead logging
turned off.";
String PERCENT_FILES_LOCAL = "percentFilesLocal";
String PERCENT_FILES_LOCAL_DESC =
- "The percent of HFiles that are stored on the local hdfs data node.";
+ "The percent of HFiles that are stored on the local hdfs data node. If not
using "
+ + "region replicas, this should equal percentFilesLocalPrimaryRegions";
+ String PERCENT_FILES_LOCAL_PRIMARY_REGIONS =
"percentFilesLocalPrimaryRegions";
+ String PERCENT_FILES_LOCAL_PRIMARY_REGIONS_DESC =
+ "The percent of HFiles used by primary regions that are stored on the
local hdfs data node. "
+ + "This is the category of locality that you want to reach 100% when
using region replicas";
String PERCENT_FILES_LOCAL_SECONDARY_REGIONS =
"percentFilesLocalSecondaryRegions";
String PERCENT_FILES_LOCAL_SECONDARY_REGIONS_DESC =
- "The percent of HFiles used by secondary regions that are stored on the
local hdfs data node.";
+ "The percent of HFiles used by secondary regions that are stored on the
local hdfs data node. "
+ + "This is not likely to reach 100%";
Review Comment:
Theoretically that's possible. I say it's unlikely because something would
need to ensure that all the block replicas for a secondary region end up
co-located with the region, and nothing I'm aware of would do that. Compactions
won't help. Internally at hubspot we have the locality healer, but today even
that doesn't know about secondary regions, although I plan on that eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
