[ 
https://issues.apache.org/jira/browse/HBASE-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432242#comment-13432242
 ] 

Jonathan Hsieh commented on HBASE-6516:
---------------------------------------

[~grace.huang]  Hm.. maybe we should fix FSTableDescriptors.getTableDescriptor 
methods instead of this?  If you look at the current code, depending on how you 
interpret it, the public three arg method is inconsistent with its public two 
argument counterpart.  

So either:
1) the three arg version wrongly has a 'throws IOException' in its signature, 
and its two argument counterpart should also not throw exceptions, *or*
2) the three argument version throw exceptions and the two argument counterpart 
should throw as well.  

I think I prefer #2.  What do you think?


                
> hbck cannot detect any IOException while ".tableinfo" file is missing
> ---------------------------------------------------------------------
>
>                 Key: HBASE-6516
>                 URL: https://issues.apache.org/jira/browse/HBASE-6516
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jie Huang
>         Attachments: hbase-6516-v2.patch, hbase-6516.patch
>
>
> HBaseFsck checks those missing .tableinfo files in loadHdfsRegionInfos() 
> function. However, no IoException will be catched while .tableinfo is 
> missing, since "FSTableDescriptors.getTableDescriptor" doesn't throw any 
> IoException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to