Apache9 commented on code in PR #5766:
URL: https://github.com/apache/hbase/pull/5766#discussion_r1942477826
##########
bin/hbase:
##########
@@ -221,6 +221,14 @@ if [ "$HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP" != "true" ]
; then
HADOOP_IN_PATH=$(PATH="${HADOOP_HOME:-${HADOOP_PREFIX}}/bin:$PATH" which
hadoop 2>/dev/null)
fi
+#If Hadoop is not specified with HADOOP_HOME, check that the assembly includes
Hadoop
+if [[ -z "${HADOOP_IN_PATH}" && ! -e "lib/hadoop-common*" ]] ; then
Review Comment:
I think the problem here is that, we should not directly use
'lib/hadoop-common*', since we may execute the script in any directory...
Let's add the ${HBASE_HOME} prefix here... @stoty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
