rmdmattingly commented on code in PR #6651:
URL: https://github.com/apache/hbase/pull/6651#discussion_r1959700339
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:
##########
@@ -439,22 +466,25 @@ boolean needsBalance(TableName tableName,
BalancerClusterState cluster) {
costFunctions);
LOG.info(
"{} - skipping load balancing because weighted average imbalance={} <=
"
- + "threshold({}). If you want more aggressive balancing, either
lower "
+ + "threshold({}) and conditionals do not have opinionated move
candidates. "
+ + "consecutive balancer runs. If you want more aggressive balancing,
either lower "
+ "hbase.master.balancer.stochastic.minCostNeedBalance from {} or
increase the relative "
+ "multiplier(s) of the specific cost function(s). functionCost={}",
isByTable ? "Table specific (" + tableName + ")" : "Cluster wide",
total / sumMultiplier,
minCostNeedBalance, minCostNeedBalance, functionCost());
} else {
- LOG.info("{} - Calculating plan. may take up to {}ms to complete.",
- isByTable ? "Table specific (" + tableName + ")" : "Cluster wide",
maxRunningTime);
+ LOG.info(
+ "{} - Calculating plan. may take up to {}ms to complete.
currentCost={}, targetCost={}",
+ isByTable ? "Table specific (" + tableName + ")" : "Cluster wide",
maxRunningTime, total,
Review Comment:
good thought, I'll make sure this logging is updated to mention conditionals
as well as add the cost context here (I did this when finding the bugs we fixed
ahead of this PR). I'm open to updating the time format too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
