Lars Hofhansl created HBASE-6579:
------------------------------------

             Summary: Unnecessary KV order check in StoreScanner
                 Key: HBASE-6579
                 URL: https://issues.apache.org/jira/browse/HBASE-6579
             Project: HBase
          Issue Type: Bug
            Reporter: Lars Hofhansl
            Priority: Minor
             Fix For: 0.96.0, 0.94.2


In StoreScanner.next(List<KeyValue>, int, String) I find this code:
{code}
      // Check that the heap gives us KVs in an increasing order.
      if (prevKV != null && comparator != null
          && comparator.compare(prevKV, kv) > 0) {
        throw new IOException("Key " + prevKV + " followed by a " +
            "smaller key " + kv + " in cf " + store);
      }
      prevKV = kv;
{code}

So this checks for bugs in the HFiles or the scanner code. It needs to compare 
each KVs with its predecessor. This seems unnecessary now, I propose that we 
remove this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to