[ https://issues.apache.org/jira/browse/HBASE-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434891#comment-13434891 ]
Hadoop QA commented on HBASE-6550: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541006/HBase-6550-v4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2579//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2579//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2579//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2579//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2579//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2579//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2579//console This message is automatically generated. > Refactoring ReplicationSink to make it more responsive of cluster health > ------------------------------------------------------------------------ > > Key: HBASE-6550 > URL: https://issues.apache.org/jira/browse/HBASE-6550 > Project: HBase > Issue Type: New Feature > Components: replication > Reporter: Himanshu Vashishtha > Assignee: Himanshu Vashishtha > Fix For: 0.96.0, 0.94.2 > > Attachments: 6550-havealook.txt, HBase-6550.patch, > HBase-6550-v1.patch, HBase-6550-v3.patch, HBase-6550-v4.patch > > > ReplicationSink replicates the WALEdits in the local cluster. It uses native > HBase client to insert the mutations. Sometime, it takes a while to process > it (may be due to region splitting, gc pause, etc) and it undergoes the > retrial phase. > It has two repercussions: > a) The regionserver handler which is serving the request (till now, a > priority handler) is blocked for this period. > b) The caller may get timed out and it will retry it anyway, but the handler > serving the ReplicationSink requests is still working. > Refactoring ReplicationSink to have the following features: > a) Making it more configurable (have its own number of retrial limit, > connection timeout, etc) > b) Add a fail fast behavior so that it bails out in case caller is timedout, > or any exception in processing the mutation batch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira